Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite session validation code to not use callbacks #2310

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Rewrite session validation code to not use callbacks #2310

merged 1 commit into from
Dec 6, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Dec 4, 2022 •
edited
Loading

Just like #2286 we can replace the activity callbacks that don't work all the time with something better.

Changes

  • Add ActivityAuthenticationExtensions. It adds the validateAuthentication() function to activities which (as the name suggests) validates the authentication. When no session is found it opens the startupactivity. We might be able to extend this in the future to restore the last session in a runBlocking {} call. I haven't tried that though.

Issues

Likely fixes #2057
Likely fixes #2233
Likely fixes #2049
Likely fixes #1883

@nielsvanvelzen nielsvanvelzen added refactor Improvements to code realiability, readability and quality crash Bug causing app crashes labels Dec 4, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Dec 4, 2022
@nielsvanvelzen nielsvanvelzen merged commit a6729a7 into jellyfin:master Dec 6, 2022
@nielsvanvelzen nielsvanvelzen deleted the auth-extensions branch December 10, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crash Bug causing app crashes refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
1 participant
@nielsvanvelzen