Add media management preference #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -170,8 +170,9 @@ | |||
| super.onResume() | |||
|
|
|||
| //React to deletion | |||
| if (currentRow != null && currentItem != null && currentItem!!.getItemId() != null && currentItem!!.getItemId().equals(dataRefreshService.lastDeletedItemId)) { | |||
| if (currentRow != null && currentItem != null && currentItem?.baseItem != null && currentItem!!.baseItem!!.id == dataRefreshService.lastDeletedItemId) { | |||
Check warning
Code scanning / detekt
Complex conditions should be simplified and extracted into well-named methods if necessary.
| @@ -170,8 +170,9 @@ | |||
| super.onResume() | |||
|
|
|||
| //React to deletion | |||
| if (currentRow != null && currentItem != null && currentItem!!.getItemId() != null && currentItem!!.getItemId().equals(dataRefreshService.lastDeletedItemId)) { | |||
| if (currentRow != null && currentItem != null && currentItem?.baseItem != null && currentItem!!.baseItem!!.id == dataRefreshService.lastDeletedItemId) { | |||
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style.
neuroid
reviewed
Jan 14, 2023
app/src/main/java/org/jellyfin/androidtv/ui/itemdetail/FullDetailsFragment.java
Outdated
Show resolved
Hide resolved
The option only shows when the user has permissions to delete the displaying item
nielsvanvelzen
force-pushed
the
media-management
branch
from
ea58d55
to
2395b61
Compare
crobibero
reviewed
Jan 26, 2023
crobibero
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new preference shows a delete option for items when the user has permissions to delete the displaying item. This is a rewritten implementation of the previous delete option that was removed in 0.15.
Changes
Issues
Fixes #2368