Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite details row with constraint layout #3729

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Rewrite details row with constraint layout #3729

merged 1 commit into from
Jul 7, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Add rounding to ExpandableTextView focus background
  • Rewrite DetailsRowView with a constraint layout
    • Mostly looks the same, with some small differences
    • Content area is now wider (e.g. item description)
    • Title/infoview/genres are now wider
    • Remove progress overlay in DetailsRowView (resume button already indicates progress and it was hidden items with logos already)

Screenshots
9750000385
9220000386

Issues

Fixes #3721

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jul 7, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 7, 2024
@nielsvanvelzen nielsvanvelzen merged commit eacbfe7 into jellyfin:master Jul 7, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the details-row-refactor branch July 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Media tags cut off
2 participants
@nielsvanvelzen @crobibero