Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to use latest verified version of credentials plugin #31

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

mikecirioli
Copy link
Contributor

When a plugin was depending on older version of credentials plugin it causes findbugs-annotations.jar to be included in packaging. This should bring things more closer to actual user environments (upgraded to credentials 2.x)

@reviewbybees

@ghost
Copy link

ghost commented Sep 26, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@batmat
Copy link
Member

batmat commented Sep 26, 2017

So I would approve it, but the PR build fails because actually this plugin is still configured to be compatible withJava 6, when credentials-2.x bumped to 7.

I guess we could bump to 7 too here? WDYT @andresrc

@andresrc
Copy link
Contributor

@batmat no problem, just bump the baseline as well to 1.625.3 or later (checking it is >= the baseline in the dependencies, of course).

Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝
from a JUnit testing perspective, it's probably better indeed as I expect many users out there actually run a more recent of credentials, and probably 2.x

@batmat
Copy link
Member

batmat commented Sep 26, 2017

@reviewbybees done

@andresrc andresrc merged commit 9d2bb5c into jenkinsci:master Sep 28, 2017
@mikecirioli mikecirioli deleted the bump_latest_creds branch September 28, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants