Make the session token duration (or expiration) configurable by the user #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-dinu
force-pushed
the
feature/make-session-token-duration-updatable
branch
from
a131d9c
to
65e884c
Compare
mihai-dinu
force-pushed
the
feature/make-session-token-duration-updatable
branch
from
65e884c
to
7cee60f
Compare
andresrc
requested changes
Jan 30, 2019
|
|
||
| /** | ||
| * Old data bound constructor. It is maintained to keep binary compatibility with clients that were using it directly. | ||
| */ | ||
| public AWSCredentialsImpl(@CheckForNull CredentialsScope scope, @CheckForNull String id, | ||
| @CheckForNull String accessKey, @CheckForNull String secretKey, @CheckForNull String description) { | ||
| this(scope, id, accessKey, secretKey, description, null, null); | ||
| this(scope, id, accessKey, secretKey, description, null, null, null); |
There was a problem hiding this comment.
We have to keep the existing constructors to maintain binary compatibility. Instead of changing constructor, add new ones (moving the @DataBoundConstructor to the appropriate one) or use a @DataBoundSetter for the new field.
nathandines
pushed a commit
to nathandines/aws-credentials-plugin
that referenced
this pull request
Feb 14, 2019
…he existing constructor Recommendation based off of comment here: jenkinsci#43 (comment)
nathandines
pushed a commit
to nathandines/aws-credentials-plugin
that referenced
this pull request
Feb 15, 2019
…he existing constructor Recommendation based off of comment here: jenkinsci#43 (comment)
nathandines
pushed a commit
to nathandines/aws-credentials-plugin
that referenced
this pull request
Feb 23, 2019
…he existing constructor Recommendation based off of comment here: jenkinsci#43 (comment)
nathandines
pushed a commit
to nathandines/aws-credentials-plugin
that referenced
this pull request
Feb 24, 2019
…he existing constructor Recommendation based off of comment here: jenkinsci#43 (comment)
nathandines
pushed a commit
to nathandines/aws-credentials-plugin
that referenced
this pull request
Feb 24, 2019
…he existing constructor Recommendation based off of comment here: jenkinsci#43 (comment)
|
Superseded by #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will allow a user to configure the session token duration to something more than the default (1 hour).
The duration is in seconds. In most cases, the AWS role needs to be changed to allow a session token for longer than 1 hour, but this is a trivial thing to do through the AWS console.