[JENKINS-60057] AssumeRole does not honour proxy settings #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escoem
requested changes
Nov 5, 2019
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
escoem
approved these changes
Nov 6, 2019
jglick
approved these changes
Nov 25, 2019
| Jenkins instance = Jenkins.getInstanceOrNull(); | ||
|
|
||
| if (instance == null) { | ||
| return null; |
There was a problem hiding this comment.
Is .withClientConfiguration(null) even valid? I would just use .get() since in this context we expect Jenkins to be running.
| return null; | ||
| } | ||
|
|
||
| ProxyConfiguration proxy = instance.proxy; |
There was a problem hiding this comment.
Instead of the above null check, could use
Suggested change
| ProxyConfiguration proxy = instance.proxy; | |
| ProxyConfiguration proxy = instance != null ? instance.proxy : null; |
|
yes @jglick , it has been tested. |
|
@escoem could you cut a release to get this in? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of
The idea is that AssumeRole gets the proxy configuration from Jenkins.