fix: typescript promise type #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspears
commented
Sep 20, 2022
|
Awesome! Thank you for the PR @jspears. I’m pretty busy this week, so I may not have time to review this until the weekend. I will follow up here when I can! |
jeremyckahn
requested changes
Sep 24, 2022
There was a problem hiding this comment.
This is looking great so far @jspears! Thanks for the work you've put into this so far. I noticed one JSDoc description that might need to be modified, but that's it.
Comment on lines
+563
to
+565
| * @param {function=} onFulfilled Receives {@link shifty.promisedData} as the | ||
| * first parameter. | ||
| * @param {function} onRejected Receives {@link shifty.promisedData} as the | ||
| * @param {function=} onRejected Receives {@link shifty.promisedData} as the |
jeremyckahn
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Thank you for the fix @jspears! I will merge this now and release it as a patch update.
|
This has been released in 2.19.1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tweenable interface is not satisfying typescript definition of a promise. This is a slight annoyance when using the
awaitfor a tweenable, as typescript complains it is not a promise. This PR finishes the promise implementation, adds the interface in typescript, and adds a test for good measure.