Pre-commit config, linting, and type hints #13
Conversation
Sure that would be nice. And it would be actually great if GHA would be used for all the CI related activities. |
sondrelg
force-pushed
the
pre-commit
branch
4 times, most recently
from
2f669cb
to
a8af98b
Compare
.github/workflows/test.yml
Outdated
| run: pip install -e . | ||
| - name: Run tests | ||
| run: | | ||
| pytest --cov=pytest_diff --verbose --assert=plain |
There was a problem hiding this comment.
Aren't we now running the tests with both Travis and GHA?
There was a problem hiding this comment.
I've never used Travis. How is that configured? Don't see any traces of it in the repo or elsewhere 😛
There was a problem hiding this comment.
sondrelg
force-pushed
the
pre-commit
branch
3 times, most recently
from
39488bc
to
939b6b7
Compare
Workflow now seems to work (see here) 🎉 I removed tests from the flake8-ignore list, added mypy, and added configs for the flake8-packages used 🙂 UPDATE: And I removed python 3.10 for now - there was an error there that I think might be something we can fix in #14 instead 👍 |
Hi @jerry-git 🙂
I'm going to sit down and have a go at writing the implementation suggested in #11 to see if it works.
I noticed that there was a pre-commit config in the project but that it maybe wasn't fully functional, so I've updated it (let me know if you prefer to remove some of the hooks I've added), run it on the project, and added type hints to the project. Hope that's something you want.
Opening this as an initial PR so it doesn't affect the diff for the next PR(s) 🙂
If you want, I could also add a linting workflow and/or test workflow to the project to run on pull-requests