average price is now computed as weighted mean instead of simple mean

jessy-bgl · Jul 28, 2022 · 6855e06 · 6855e06
1 parent 059309f
commit 6855e06
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/usecases/statistics/dca-transactions-summary.usecase.ts b/server/src/usecases/statistics/dca-transactions-summary.usecase.ts
@@ -1,5 +1,5 @@
 import { Injectable, NotFoundException } from '@nestjs/common';
-import { sumBy, meanBy, round } from 'lodash';
+import { sumBy, sum, round } from 'lodash';
 
 import { IDcaRepository } from '../../domain/repositories/dca.repository.interface';
 import { ICoinRepository } from '../../domain/repositories/coin.repository.interface';
@@ -32,7 +32,8 @@ class DcaTransactionsSummaryUseCase {
       2,
     );
     stats.avgPrice = round(
-      meanBy(transactions, (t) => t.price),
+      sum(transactions.map((tr) => tr.size * tr.price)) /
+        sumBy(transactions, (tr) => tr.size),
       2,
     );
     stats.currentValue = round(stats.totalSize * currentPrice, 2);