chore: bump typescript-eslint to v8 #1623
Conversation
| '@typescript-eslint/ban-types': 'error', | ||
| '@typescript-eslint/no-empty-object-type': 'error', | ||
| '@typescript-eslint/no-unsafe-function-type': 'error', | ||
| '@typescript-eslint/no-wrapper-object-types': 'error', |
There was a problem hiding this comment.
ban-types is removed in typescript-eslint v8. Its default options are now split among those three rules.
| requiresTypeChecking?: boolean; | ||
| } | ||
|
|
||
| export const createRule = ESLintUtils.RuleCreator<JestPluginDocs>(name => { |
There was a problem hiding this comment.
https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#custom-rule-metadocs-types
In theory there's no hard need in plugins to mention requiresTypeChecking anymore... except, in practice eslint-doc-generator reads it. Also this repo uses it for more doc generation configuration:
Not at all! Please keep the engagement up 🙂 |
|
@JoshuaKGoldberg are you working on this? typescript-eslint 8 is released and it would be great to update this repo to add support for it. If you are too busy to go for it, would it be ok to submit another PR to add support for typescript-eslint 8? |
| @@ -106,7 +106,7 @@ | |||
| "typescript": "^5.0.4" | |||
| }, | |||
| "peerDependencies": { | |||
| "@typescript-eslint/eslint-plugin": "^6.0.0 || ^7.0.0", | |||
| "@typescript-eslint/eslint-plugin": "*", | |||
There was a problem hiding this comment.
Are we sure every @typescript-eslint/eslint-plugin would be a valid peer?
|
🎉 This issue has been resolved in version 28.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👋 Hi! Coming over from typescript-eslint/typescript-eslint#9501: we're working on typescript-eslint v8 and would like to try the beta out on plugins such as
eslint-plugin-jest.I'm sending this draft PR as a reference to see what issues we might give you in upgrading and to try to be helpful. If this is annoying noise to you, please forgive me, I'll withdraw the PR. But I hope this is useful on your end - and please let me know if you have any feedback! ❤️