Improve sound configurability #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and add a reminder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to mute the tune that plays when heaters reach their target temperature. The tune may be helpful to troubleshoot heater problems, but when actively changing extruder temperatures to combat oozing in a dual extrusion print it plays twice each layer and becomes annoying quickly.
Setting the option to OFF will only mute the tune while a print is active, in all other cases it will play as usual (i.e. during filament loading, or while the print is paused).
The setting is stored in one of the 12 EEPROM bytes reserved for buzzer settings. Apparently there were vague plans to store actual tunes in there, I removed the remnants of this idea.
Also included is a fix for the half-broken M72 command, which finally makes available the tunes that have until now been wasting space in everyone's flash chips without being accessible. Now all 8 tunes can be played in G-code, but this will require a fix in GPX as well. I find no explanations why the tune ID is clipped to 2 in both Sailfish and GPX. If the reason was that G-code shouldn't be allowed to play system tunes, it would make more sense to clip the ID to 5.