Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Threaded threads #78

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Commits on May 30, 2020

  1. textareas and inputs in bulmaswatch-darkly were hurting my eyes.

    (#fff) is not a good background color to compose posts in, that are then displayed with the dark background color.
    Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    bf0394c View commit details
    Browse the repository at this point in the history
  2. Support feature_set= other than mainline for Mastodon

    Pleroma will send records that cause brutaldon to make pleroma-specific responses, which the mastodon python module wigs out on claiming it doesn't support that "feature set" so allow for a feature set to be specified...
    Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    2dfdb0b View commit details
    Browse the repository at this point in the history
  3. Handle feature_set errors automatically

    Recreate the mastodon object if there's an error complaining about a missing feature set. Only happens for status_post I think. Could be further generalized...
    Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    12d7b4c View commit details
    Browse the repository at this point in the history
  4. Refactoring preferences to be more cohesive

    No need to list the preference fields three times in three places in the code. A class decorator ought to be able to sleuth them out from the model itself. Should make it easier to add new preferences.
    Cy authored and Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    0b93eb7 View commit details
    Browse the repository at this point in the history
  5. Foreign keys add magic members

    Because when you add one field to a class, you clearly want to add two fields to a class, and there's no need to consider the field you never asked to add to be something other than a field.
    Cy authored and Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    0439440 View commit details
    Browse the repository at this point in the history
  6. Allow previewing sensitive images

    A setting to not censor sensitive images if you think you're not in danger for looking at them.
    Cy committed May 30, 2020
    Configuration menu
    Copy the full SHA
    39f13d6 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2020

  1. Add open_details preference

    Add a preference to open details by default.
    Cy committed May 31, 2020
    Configuration menu
    Copy the full SHA
    543a83c View commit details
    Browse the repository at this point in the history
  2. Missed a few status_post calls

    Cy committed May 31, 2020
    Configuration menu
    Copy the full SHA
    c0caab4 View commit details
    Browse the repository at this point in the history
  3. whoops, left an old mistake in the code

    Cy committed May 31, 2020
    Configuration menu
    Copy the full SHA
    9415def View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Viewing threads as a tree, not flattened

        I couldn't tell who was replying to whom, so I thought I'd give a shot at implementing a tree of threads, instead of a flattened list, with only the root distinguishable from the rest.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    7b86cf7 View commit details
    Browse the repository at this point in the history
  2. Cleaning up, adding tokens

    Doing some token based temporary flattening for django
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4e94878 View commit details
    Browse the repository at this point in the history
  3. Debugging a lookup error

    It was saying stuff was unhashable, but I thought I was just hashing by post ID.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    4faba56 View commit details
    Browse the repository at this point in the history
  4. Still trying to figure out what my data structure is

    Python's dynamic typing doesn't make this easy...
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    82b2c9f View commit details
    Browse the repository at this point in the history
  5. OK no hashable errors anymore

    I think I got it working.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2c8cdac View commit details
    Browse the repository at this point in the history
  6. Adding an outer IN/OUT

    If we have multiple roots ever, we need the whole thing in a big <ul></ul>
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2308d65 View commit details
    Browse the repository at this point in the history
  7. Trying to figure out why only the root post is coming through

    Is nothing in reply to the root post? Nothing at all?
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    933961b View commit details
    Browse the repository at this point in the history
  8. Nothing at all?

    More debugging...
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    631c140 View commit details
    Browse the repository at this point in the history
  9. Monitor tree building progress

    Trying to find why only the one post comes out with no replies
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    7552f4e View commit details
    Browse the repository at this point in the history
  10. Still trying...

    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    cc826ff View commit details
    Browse the repository at this point in the history
  11. Maybe the root is getting filtered out?

    I can't imagine how, but...#
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    e887978 View commit details
    Browse the repository at this point in the history
  12. Yet more debugging

    Trying to find how to thread stuff is harder than I thought it would be. Where's the root?
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    09c5a4f View commit details
    Browse the repository at this point in the history
  13. Sorting to make it easier to read when debugging

    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    43cb98a View commit details
    Browse the repository at this point in the history
  14. Removing redundant code

    The top level roots acts like any other level, I noticed.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    e8b5cf6 View commit details
    Browse the repository at this point in the history
  15. Leftovers?

    Trying to add the leftover toots that don't reply to anything at the end.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    05605bf View commit details
    Browse the repository at this point in the history
  16. Leftovers isn't lazy enough

    1) initialize seen to empty
    2) get all posts not in seen
    3) add posts to seen because the generator was iterated over lazily
    4) wonder why it looks like there weren't any posts in seen
    
    yeah... leftovers has to be lazy too.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    e76c758 View commit details
    Browse the repository at this point in the history
  17. auto 0 20 244

    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    3d96963 View commit details
    Browse the repository at this point in the history
  18. Pulling any missing posts by ID

    We have the post ID, so why would Pleroma not send us the post? Request any missing posts it hasn't sent us, to try and get a thread that doesn't lose all its replies.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    8cda922 View commit details
    Browse the repository at this point in the history
  19. Consistent naming

    Right, I forgot I was in the middle of changing the name post to toot. Thus explaining why op.post had an empty result, since op.toot was what I changed.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    5187715 View commit details
    Browse the repository at this point in the history
  20. The root post is not included in its descendants

    Oh for Pete's sake I'm an idiot. The descendants array isn't going to contain the root post at all, because it's totally separate. That's the missing post everything was trying to reply to!
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2cf2e77 View commit details
    Browse the repository at this point in the history
  21. Why is the root post displaying twice?

    I thought the root post only displayed once. Maybe it needs to be removed?
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    f900be0 View commit details
    Browse the repository at this point in the history
  22. The template prints out the root by itself

    Right, the template is where the duplication of the root is, since now the root is just the first "descendant" in the tree.
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b306f38 View commit details
    Browse the repository at this point in the history
  23. Changing the template, prettifying a bit

    Now that everything is a <li> can set the margin-top value to make a gap, instead of making a visible "invisible" hr. And with the template thread.html fixed, it seems to be working, showing everything as a tree, instead of a flat list.
    Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a0433a1 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    50f05d7 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    d682f62 View commit details
    Browse the repository at this point in the history
  26. Merge branch 'dark_textareas' into threaded_threads

    There's a merge conflict if I try to separate out this branch...
    Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    aee3b13 View commit details
    Browse the repository at this point in the history
  27. Preference setting for whether to make threads a tree or not

    I guess it might be useful for mobile users?
    autocommit authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    77e352b View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    70e0eea View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    f2f8e7a View commit details
    Browse the repository at this point in the history
  30. Re-enable filtering

    Gah, I forgot brutaldon had client side filters
    Cy authored and Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    72c6ba5 View commit details
    Browse the repository at this point in the history
  31. Actually return the toots being looked up

    The code was looking up toots, then throwing them away because I'm an idiot.
    Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    36fc686 View commit details
    Browse the repository at this point in the history
  32. Allowing for horizontal scrolling for deeply nested threads.

    I guess I have to copypaste this into the light theme too...
    Cy committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    e2cf103 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Removing some debugging output I missed

    Cy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    2fc42ad View commit details
    Browse the repository at this point in the history