Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing semicolon in SVGGraphics2D#strokeStyle() #38

Closed
christianAppl opened this issue Apr 29, 2021 · 4 comments
Closed

Missing semicolon in SVGGraphics2D#strokeStyle() #38

christianAppl opened this issue Apr 29, 2021 · 4 comments

Comments

@christianAppl
Copy link

christianAppl commented Apr 29, 2021

A semicolon is missing for the miterLimit.
I did not check, whether you already fixed this issue in the most recent version. Sorry for the inconvenience - simply close this issue in that case.

It should be:

if (Math.abs(DEFAULT_MITER_LIMIT - miterLimit) > 0.001) {
   b.append("stroke-miterlimit: ").append(geomDP(miterLimit)).append(";");
}

But it is:

if (Math.abs(DEFAULT_MITER_LIMIT - miterLimit) > 0.001) {
   b.append("stroke-miterlimit: ").append(geomDP(miterLimit));
}

Example:
grafik
grafik

Solution:
grafik
grafik

@jfree
Copy link
Owner

jfree commented Apr 29, 2021

This is a duplicate of #36 right? The fix is already committed for the next release.

@jfree jfree closed this as completed Apr 29, 2021
@christianAppl
Copy link
Author

christianAppl commented Apr 30, 2021

It is not a duplicate of issue #36! That issue was about the miter limit not being applied at all, due to a logical error in the condition.

This ticket is about the missing semicolon for that parameter (.append(";")) - an issue I had not seen then. If said semicolon is already appended in the current version - everything is perfectly fine.

The missing semicolon is preventing the following parameter from being applied (as you can see in the screenshots).

(Due to the different timezone my responses can take some time.)

@jfree
Copy link
Owner

jfree commented Apr 30, 2021

Oops, let me look again.

@jfree jfree reopened this Apr 30, 2021
jfree added a commit that referenced this issue Apr 30, 2021
@jfree
Copy link
Owner

jfree commented Apr 30, 2021

Fixed

@jfree jfree closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants