Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Frogbot workflows #13

Merged
merged 5 commits into from
May 24, 2023
Merged

Add Frogbot workflows #13

merged 5 commits into from
May 24, 2023

Conversation

EyalDelarea
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label May 22, 2023
eyalbe4
eyalbe4 suggested changes May 23, 2023
View reviewed changes
Copy link

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's remove from the new Frogbot workflow all the lines which are commented out.
  • Why don't we also add the scan repository workflow as well?
  • Let's also add the Frogbot badge to the README.

@EyalDelarea
Copy link
Contributor Author

  • Why don't we also add the scan repository workflow as well?

Scan repository is not supported in Gradle yet.

@EyalDelarea EyalDelarea merged commit 90b5f39 into jfrog:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees

@omerzi omerzi

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EyalDelarea @eyalbe4 @omerzi