Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-JSON responses #54

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Handle non-JSON responses #54

merged 1 commit into from
Aug 17, 2017

Conversation

andor44
Copy link
Contributor

@andor44 andor44 commented Aug 4, 2017

Fix for #53

@andor44
Copy link
Contributor Author

andor44 commented Aug 4, 2017 •
edited
Loading

Note that this will still fail responses that aren't UTF8-encodable strings, ie. binary data like that returned from read CA will still fail. It will work with the /pem variant though, which is still a non-JSON response, but it is valid UTF-8. I'm not sure if Ansible supports returning arbitrary binary blobs.

@jhaals
Copy link
Owner

jhaals commented Aug 17, 2017

Thanks for the fix @andor44!

@jhaals jhaals merged commit 5d67a77 into jhaals:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andor44 @jhaals