Add delete button for non one-time passwords #1026
Conversation
boekkooi-lengoo
force-pushed
the
feature-delete
branch
2 times, most recently
from
125c48a
to
1573644
Compare
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
- Coverage 78.21% 76.34% -1.88%
==========================================
Files 6 6
Lines 404 427 +23
==========================================
+ Hits 316 326 +10
- Misses 58 71 +13
Partials 30 30
Continue to review full report at Codecov.
|
boekkooi-lengoo
force-pushed
the
feature-delete
branch
from
1573644
to
a2630c0
Compare
|
@jhaals I have updated the PR with the new translation method. Is there anything I can do to help get this reviewed and hopefully merged? |
boekkooi-lengoo
force-pushed
the
feature-delete
branch
from
a2630c0
to
aa34c2b
Compare
| @@ -6,5 +6,5 @@ import "github.com/jhaals/yopass/pkg/yopass" | |||
| type Database interface { | |||
| Get(key string) (yopass.Secret, error) | |||
| Put(key string, secret yopass.Secret) error | |||
| Delete(key string) error | |||
| Delete(key string) (bool, error) | |||
There was a problem hiding this comment.
What is the bool suppose to signal? I'd say returning error is enough.
There was a problem hiding this comment.
The boolean indicated if the secret was deleted or not.
This allows the correct status code to be returned in pkg/server/server.go line110-115.
I'm fine removing but to me it just seems nicer since we already require the check in deploy/aws-lambda/main.go, pkg/server/redis.go etc.
In order to allow the deletion of secrets we first need to ensure that the endpoint with method DELETE is not handled by getSecret.
In order to know if an item was deleted or not found without implementing implementation based error checking a boolean should also be returned by Delete. If an item is Deleted then the return will be `true, nil`, if an item is not found the return is `false, nil` and if an error correct the return is `false, error`.
boekkooi-lengoo
force-pushed
the
feature-delete
branch
3 times, most recently
from
5e4d572
to
429dc62
Compare
In order to avoid the `mux: route doesn't have methods` error from the CORS Middleware because `/` matches everything we now only allow its GET Method.
Because the CORS middleware is not working correctly for our use case it's easier to manually implement it.
This avoids code duplication (aka DRY).
boekkooi-lengoo
force-pushed
the
feature-delete
branch
from
429dc62
to
7db758e
Compare
|
@jhaals I have rebased this PR. Should you find any spare time to look into this it would be much appreciated 😄 P.S. Thanks for merging the fetch on demand PR 😄 |
|
Really nice work @boekkooi-lengoo! |
Hey,
First of thank you for your work in YoPass and having a look at this PR!
As requested in #333 this PR adds a delete button for the viewer of a time bound Secret.
Please let me know if there is anything missing or something needs to be updated.
Thanks again and have a great day 😄