feature: yaml lint

[sheeeng]

• Use YAML Lint in GitHub Actions.
• Fix YAML Lint issues.

$ yamllint --config-file=.github/linters/.yaml-lint.yml .
./.codeclimate.yml
  29:17     warning  empty value in block mapping  (empty-values)
  32:17     warning  empty value in block mapping  (empty-values)

./deploy/aws-lambda/serverless.yml
  30:2      warning  wrong indentation: expected 2 but found 1  (indentation)

./deploy/docker-compose/insecure/docker-compose.yml
  9:1       error    trailing spaces  (trailing-spaces)

./deploy/docker-compose/with-nginx-proxy-and-letsencrypt/docker-compose.yml
  45:9      error    trailing spaces  (trailing-spaces)
  46:9      warning  empty value in block mapping  (empty-values)
  47:11     warning  empty value in block mapping  (empty-values)
  48:8      warning  empty value in block mapping  (empty-values)
  49:11     warning  empty value in block mapping  (empty-values)

./.github/workflows/codeql-analysis.yml
  3:1       warning  truthy value should be one of [false, true]  (truthy)
  18:5      warning  wrong indentation: expected 6 but found 4  (indentation)
  48:6      warning  missing starting space in comment  (comments)

./.github/workflows/test.yml
  2:1       warning  truthy value should be one of [false, true]  (truthy)
  42:7      warning  wrong indentation: expected 4 but found 6  (indentation)

./.github/workflows/push.yml
  1:1       warning  truthy value should be one of [false, true]  (truthy)
  11:5      warning  wrong indentation: expected 6 but found 4  (indentation)

[codecov]

Codecov Report

Merging #1068 (bbd069a) into master (b82084b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1068   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files           6        6           
  Lines         403      403           
=======================================
  Hits          315      315           
  Misses         58       58           
  Partials       30       30           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e6da0...bbd069a. Read the comment docs.

[sheeeng]

Fixed once again with the correct upstream master branch.

$ git remote add upstream [email protected]:jhaals/yopass.git
$ git remote --verbose show upstream
* remote upstream
  Fetch URL: [email protected]:jhaals/yopass.git
  Push  URL: [email protected]:jhaals/yopass.git
$ git fetch --all --prune && git pull --rebase --prune upstream master

[jhaals]

are there a specific reason to why double quotes are favoured?

[sheeeng]

It is true that YAML Specification does not indicate whether double quotes or single quotes are preferred. You can decide on which one this project should use.

[sheeeng]

@jhaals, please let me know if double quotes or single quotes is the one that you preferred in this project. I will reflect that in later changes. Have a nice weekend.

[jhaals]

Thanks for the quick turnaround @sheeeng!
I'd say let's go with single quotes and then 🚢 this PR :)

[sheeeng]

@jhaals, I have quickly checked that both widely used redhat.vscode-yaml (6,629,666 installs) and esbenp.prettier-vscode (15,769,891 installs) VSCode extensions have double quotes for saving YAML files automatically. These two VSCode extensions comes handy while working with YAML files. Thus, the double quotes changes were included in this PR. Sorry for the late information.

Please confirm that you still prefer single quotes and I will modify the lint rules accordingly.

  "[yaml]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode",
    "_commented_editor.defaultFormatter": "redhat.vscode-yaml"
  },

[jhaals]

Thanks for the additional context, I don't have strong preferences in this case so let's go with this