-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: improve preformatted text display #1069
feature: improve preformatted text display #1069
Conversation
sheeeng
commented
Sep 23, 2021
- Improve preformatted text display without overflowing issue.
- Before:
- After:
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
- Coverage 80.00% 78.16% -1.84%
==========================================
Files 6 6
Lines 390 403 +13
==========================================
+ Hits 312 315 +3
- Misses 52 58 +6
- Partials 26 30 +4
Continue to review full report at Codecov.
|
Great contribution, thank you @sheeeng! |
Fixed prettier checks with c69604a, hopefully. |
seems like it's still failing on prettier, are you rebased on master? Otherwise try rebase, |
I will have a look. Sorry about the failures. |
c69604a
to
fd33abc
Compare
I have rebased from wrong master branch and ran Fixing in progress. |
fd33abc
to
c3829f0
Compare
c3829f0
to
51dd856
Compare
Fixed once again with the correct upstream master branch and ran $ git remote add upstream [email protected]:jhaals/yopass.git
$ git remote --verbose show upstream
* remote upstream
Fetch URL: [email protected]:jhaals/yopass.git
Push URL: [email protected]:jhaals/yopass.git
$ git fetch --all --prune && git pull --rebase --prune upstream master |
I have tried to check locally. @jhaals, could you try to check out this branch and see if the code matches Prettier code style on your side? As an alternative, do you have any ideas for me to further debug this issue? ➜ website git:(feature/improve-preformatted-text-display) $ yarn run lint
yarn run v1.22.10
$ prettier --ignore-path .gitignore -c .
Checking formatting...
All matched files use Prettier code style!
✨ Done in 1.09s.
➜ website git:(feature/improve-preformatted-text-display) $ yarn format
yarn run v1.22.10
$ prettier --ignore-path .gitignore -c --write .
Checking formatting...
All matched files use Prettier code style!
✨ Done in 1.05s.
➜ website git:(feature/improve-preformatted-text-display) $ |
Signed-off-by: Johan Haals <[email protected]>