Use local Roboto font #1077
Merged
Use local Roboto font #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 6 6
Lines 390 390
=======================================
Hits 312 312
Misses 52 52
Partials 26 26 Continue to review full report at Codecov.
|
In order to avoid external calls from YoPass we now embed the roboto font using the [`@fontsource/roboto`](https://fontsource.org/fonts/roboto) package. This should resolve jhaals#960.
boekkooi-lengoo
force-pushed
the
local-fonts
branch
from
a50e8ab
to
84992f4
Compare
|
Thanks for doing this @boekkooi-lengoo! Could you explain why all the imports are needed? |
|
oh I see we have all of them in the current one. I wonder if all are needed, in any way this is great. Thanks again for doing this @boekkooi-lengoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid external calls from YoPass we now embed the roboto font using the
@fontsource/robotopackage.This should resolve #960.