Add Zap Logger #1082
Merged
Add Zap Logger #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `go get -u go.uber.org/zap`. For more info see https://github.com/uber-go/zap
In order to allow for better logs with log levels. https://github.com/uber-go/zap was added as a logger using `go get -u go.uber.org/zap`.
This adds a logger, and it's usage to the YoPass server. This should help with issue jhaals#1075
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 80.00% 78.16% -1.84%
==========================================
Files 6 6
Lines 390 403 +13
==========================================
+ Hits 312 315 +3
- Misses 52 58 +6
- Partials 26 30 +4
Continue to review full report at Codecov.
|
jhaals
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Great addition! 👍 The one thing left fixing is the HTTP logging which is currently not zap.
::1 - - [06/Oct/2021:09:19:04 +0200] "GET /secret/50b5f7ff-bb2a-423b-9079-bea38652f50d HTTP/1.1" 404 32
{"level":"debug","ts":1633504746.398633,"caller":"server/server.go:104","msg":"Secret not found","error":"memcache: cache miss","key":"50b5f7ff-bb2a-423b-9079-bea38652f50d"}
::1 - - [06/Oct/2021:09:19:06 +0200] "GET /secret/50b5f7ff-bb2a-423b-9079-bea38652f50d HTTP/1.1" 404 32
::1 - - [06/Oct/2021:09:20:21 +0200] "GET / HTTP/1.1" 404 19
But I'd say lets follow that up in a separate PR.
|
👍 Thank you. I totally missed the HTTP logger. Let me see what I can do about that one. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
To help with #1075 I have added zap as a logger to YoPass.
This adds the
--log-levelargument with the default beinginfoto the server binary.I hope this is ok.
Cheers,
Warnar