Migrate from Create-React-App to Vite #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzfr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1871 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 7 7
Lines 561 561
=======================================
Hits 416 416
Misses 113 113
Partials 32 32 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jhaals
requested changes
Sep 14, 2023
website/package.json
Outdated
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "start": "vite --host", | ||
| "build": "vite", |
There was a problem hiding this comment.
Suggested change
| "build": "vite", | |
| "build": "vite build", |
fritzfr
force-pushed
the
migrate-cra-to-vite
branch
from
4dfdc77
to
5f962b8
Compare
jhaals
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the recently deprecated Create-React-App (react-scripts) with Vite.
This also allows to upgrade Typescript afterwards (#1841).