Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization support #429

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Localization support #429

merged 1 commit into from
Apr 22, 2020

Conversation

Starbix
Copy link
Contributor

@Starbix Starbix commented Apr 20, 2020

Here's the promised PR 😄
Now it's possible to change the translation simply by mounting your own json to /public/locales/en.json.
This is my first time working with React, so if anything can be optimized, tell me.

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #429 into master will increase coverage by 0.82%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   74.23%   75.06%   +0.82%     
==========================================
  Files          16       17       +1     
  Lines         361      377      +16     
  Branches       61       61              
==========================================
+ Hits          268      283      +15     
- Misses         85       86       +1     
  Partials        8        8              
Impacted Files Coverage Δ
website/src/i18n.tsx 0.00% <0.00%> (ø)
website/src/index.tsx 0.00% <0.00%> (ø)
website/src/App.tsx 100.00% <100.00%> (ø)
website/src/Create.tsx 86.53% <100.00%> (+0.82%) ⬆️
website/src/DisplaySecret.tsx 97.14% <100.00%> (+0.26%) ⬆️
website/src/Download.tsx 90.62% <100.00%> (+0.62%) ⬆️
website/src/Error.tsx 100.00% <100.00%> (ø)
website/src/Features.tsx 100.00% <100.00%> (ø)
website/src/Form.tsx 71.42% <100.00%> (+2.19%) ⬆️
website/src/Result.tsx 92.30% <100.00%> (+0.64%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31443d0...3546d4a. Read the comment docs.

@jhaals
Copy link
Owner

jhaals commented Apr 22, 2020

Looking good, thanks for the PR @Starbix

@jhaals jhaals merged commit c63568d into jhaals:master Apr 22, 2020
@Starbix
Copy link
Contributor Author

Starbix commented Apr 23, 2020

Here's our translation and modification: https://github.com/arcadesolutionsag/docker-yopass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants