Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning rack version to 1.5.2 #6

Closed
wants to merge 1 commit into from

Conversation

carlasouza
Copy link
Contributor

Yopass 2.2.0 doesn't work with rack 1.6.0, raising the following error:

App 6242 stderr: [ 2015-01-20 16:25:00.5547 6258/0x00000000a92ae0(Worker 1) utils.rb:68 ]: *** Exception NameError in Rack application object (uninitialized constant Rack::Request::QUERY_STRING) (process 6258, thread 0x00000000a92ae0(Worker 1)):
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-1.6.0/lib/rack/request.rb:24:in `query_string'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-1.6.0/lib/rack/request.rb:188:in `GET'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-1.6.0/lib/rack/request.rb:230:in `params'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:893:in `call!'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:886:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-1.6.0/lib/rack/nulllogger.rb:9:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/rack-1.6.0/lib/rack/head.rb:13:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:180:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:2014:in `call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:1478:in `block in call'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:1788:in `synchronize'
App 6242 stderr:    from /var/lib/gems/2.0.0/gems/sinatra-1.4.5/lib/sinatra/base.rb:1478:in `call'
App 6242 stderr:    from /usr/lib/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:77:in `process_request'
App 6242 stderr:    from /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:142:in `accept_and_process_next_request'
App 6242 stderr:    from /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop'
App 6242 stderr:    from /usr/lib/ruby/vendor_ruby/phusion_passenger/request_handler.rb:448:in `block (3 levels) in start_threads'

@jhaals
Copy link
Owner

jhaals commented Jan 23, 2015

Hi @carlasouza, sorry for the late reply.
I'd like to run on the latest version so the app don't fall behind on security updates.
Let's see if this can be patched somehow. How are you starting/running the app when it crashes like this? Apache/Passenger?

@jhaals
Copy link
Owner

jhaals commented Jan 23, 2015

yeah it's really broken, just tried setting it up myself. The rack dependency in the .gemspec need to be specified as well in order for it to work with gem install yopass

@jhaals jhaals closed this in c804ade Jan 24, 2015
jhaals pushed a commit that referenced this pull request Jan 24, 2015
@jhaals
Copy link
Owner

jhaals commented Jan 24, 2015

@carlasouza this should be working in 2.2.2.
I'm going to do a overhaul of the project during the upcoming weeks.

@carlasouza
Copy link
Contributor Author

@jhaals thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants