Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect consolidated secret URL paths in CLI #802

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

grobie
Copy link
Contributor

@grobie grobie commented Mar 7, 2021

The UI consolidated the different paths (#798) used to describe secrets.
This change reflects this change in the CLI to ensure it returns valid
URLs.

Fixes #799.

The UI consolidated the different paths (jhaals#798) used to describe secrets.
This change reflects this change in the CLI to ensure it returns valid
URLs.

Fixes jhaals#799.
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #802 (0020581) into master (181538a) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   78.81%   78.57%   -0.25%     
==========================================
  Files           6        6              
  Lines         354      350       -4     
==========================================
- Hits          279      275       -4     
  Misses         49       49              
  Partials       26       26              
Impacted Files Coverage Δ
pkg/yopass/yopass.go 78.66% <100.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6f8d8...0020581. Read the comment docs.

@grobie
Copy link
Contributor Author

grobie commented Mar 7, 2021

Merging #802 (0020581) into master (181538a) will decrease coverage by 0.24%.

🤨

@jhaals
Copy link
Owner

jhaals commented Mar 8, 2021

That math does not add up to me!

@jhaals jhaals merged commit 3204c51 into jhaals:master Mar 8, 2021
@grobie grobie deleted the 799 branch March 8, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust CLI URL generation
2 participants