Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protractor or another tool for client e2e tests #101

Closed
ghost opened this issue Feb 3, 2020 · 5 comments · Fixed by #188
Closed

Protractor or another tool for client e2e tests #101

ghost opened this issue Feb 3, 2020 · 5 comments · Fixed by #188
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ Feature New feature v1.4.0 1.4.0 Release label $200 https://www.jhipster.tech/bug-bounties/
Projects
nodejs blueprint
Milestone
1.4.0

Comments

@ghost
Copy link

ghost commented Feb 3, 2020

Add default choose for client e2e tests
@ghost ghost changed the title Protactor or another tool for client e2e tests Protractor or another tool for client e2e tests Feb 3, 2020
@ghost ghost added this to the 1.0.0 milestone Feb 4, 2020
@ghost ghost added this to To do in nodejs blueprint via automation Feb 4, 2020
@ghost ghost added Feature New feature v1.0.0 First stable version labels Feb 4, 2020
@ghost ghost removed the v1.0.0 First stable version label Mar 23, 2020
@ghost ghost removed this from the 1.0.0 milestone Mar 24, 2020
@mraible
Copy link
Contributor

mraible commented Aug 21, 2020

Can't you use the same client testing tool that the main generator uses? I'm not sure why a backend framework would need to override this.

@ghost
Copy link
Author

ghost commented Aug 21, 2020

Hi @mraible , yes in fact the the issue is to apply protractor also for backend. The added title ("or onother tool") is to keep open the investigation if there is another tool more performant for nodejs.

@ghost
Copy link
Author

ghost commented Aug 21, 2020 •
edited by ghost
Loading

@mraible, excuse me, now for the unit and e2e backend tests there is jest, so it is only required to add protractor as default in the generation for the client side (now the e2e client tests are not generated).

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Oct 14, 2020
@ghost ghost added the v1.4.0 1.4.0 Release label label Nov 10, 2020
@ghost ghost self-assigned this Nov 16, 2020
@ghost ghost moved this from To do to In progress in nodejs blueprint Nov 16, 2020
This was referenced Nov 25, 2020
Closed
Closed
@ghost ghost linked a pull request Nov 30, 2020 that will close this issue
Feature/protractor issue101 #188
Merged
@ghost
Copy link
Author

ghost commented Nov 30, 2020

Hi @mraible . Finally I'm able to reach this feature. There is a lot of stuff done (I had to implement the user management api, fix nestJS routing with angular/react, run the e2e tests for admin and entities, create new tests and jobs for every combination in the pipelines).

Please check it. Every improvements and suggestions are welcome!

@ghost ghost closed this as completed in #188 Dec 1, 2020
nodejs blueprint automation moved this from In progress to Done Dec 1, 2020
@ghost
Copy link
Author

ghost commented Dec 1, 2020

$200 bug bounty claim: https://opencollective.com/generator-jhipster/expenses/28939

@ghost ghost added this to the 1.4.0 milestone Dec 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ Feature New feature v1.4.0 1.4.0 Release label $200 https://www.jhipster.tech/bug-bounties/
Projects
nodejs blueprint
  
Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Feature/protractor issue101 jhipster/generator-jhipster-nodejs
1 participant
@mraible