Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/protractor issue101 #188

Merged
43 commits merged into from
Dec 1, 2020
Merged

Feature/protractor issue101 #188

43 commits merged into from
Dec 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2020

Integrate protractor e2e client tests with new test integration pipelines, new server api implemented, angular/react routing fix.

@mraible
Copy link
Contributor

mraible commented Nov 30, 2020

If the tests for this PR have Protractor enabled, and they pass, then I'll approve this PR.

@ghost
Copy link
Author

ghost commented Nov 30, 2020

All the jobs with a client framework runs protractor tests (it is a default). But I don't know why protractor for some entity tests randomly fails (the error is always the same, but occours every time in different react app configured, while in the last time it was in success):

TimeoutError: Failed while waiting for "By(css selector, #entity-menu)" of Page Object Class '' to display.

@mraible some suggestions? It seems that sometimes protractor does not find the entity menu navbar (it is strange because it randomly fails in different tests).

You can check that with the same commit, runs two builds for the same job, triggered by two events (push on branch, and pull request). But it is weird that one is ok and the other is in failure...

@ghost ghost force-pushed the feature/protractor-issue101 branch 14 times, most recently from 41114de to 28757ff Compare December 1, 2020 13:44
@ghost ghost force-pushed the feature/protractor-issue101 branch 2 times, most recently from 7bdcef9 to 16dad6b Compare December 1, 2020 14:51
@ghost ghost force-pushed the feature/protractor-issue101 branch from 16dad6b to 754517e Compare December 1, 2020 15:06
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@ghost
Copy link
Author

ghost commented Dec 1, 2020

All the jobs with a client framework runs protractor tests (it is a default). But I don't know why protractor for some entity tests randomly fails (the error is always the same, but occours every time in different react app configured, while in the last time it was in success):

TimeoutError: Failed while waiting for "By(css selector, #entity-menu)" of Page Object Class '' to display.

@mraible some suggestions? It seems that sometimes protractor does not find the entity menu navbar (it is strange because it randomly fails in different tests).

You can check that with the same commit, runs two builds for the same job, triggered by two events (push on branch, and pull request). But it is weird that one is ok and the other is in failure...

Hi @mraible, now it's all ok and passed. The issue is caused by some server api that run random errors log in the react client pages: d88ecc4

nodejs blueprint automation moved this from In progress to Reviewer approved Dec 1, 2020
@ghost
Copy link
Author

ghost commented Dec 1, 2020

Thanks!

@ghost ghost merged commit 920d3d7 into main Dec 1, 2020
nodejs blueprint automation moved this from Reviewer approved to Done Dec 1, 2020
@ghost ghost deleted the feature/protractor-issue101 branch December 1, 2020 15:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
1 participant