-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/protractor issue101 #188
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
e0abcbd
enable protractor
329b1c3
try resolve error compilation protractor
c447cf4
update release notes and shelljs version for warnings
0e2a630
adding client e2e tests in pipeline
149b508
run for e2e client test
8d74a88
update protractor version 5.4.3
c0be481
customize protractor
9368cc3
try update angular protractor for run on pipeline
081d6ac
added new package-lock
aaf7431
update gitignore
29ebf0a
update protractor files
352ef64
fix some tests admin e2e client
eb43334
fix i18n title client page
d2b825c
try upgrade google-chrome
81f9b0f
implement change password
cd11058
adding routing angular in nestjs
88051d1
enable admin botton
93b5635
added docker compose keycloak task
5d0ad50
modify pipeline for run keycloak
b3129b4
change node version in 10.23.0
fb361e3
enable user management admin button for client angular-react
b284ba4
added user registration api
8ea2a3b
test change password
08b2b85
update common README
c6152fd
modify pipeline test integration
d35eb16
review pipeline
b6d8acb
change bash command scritps
d4b80a9
added e2e client templates
071ce23
replace last e2e entity templates
97a73eb
comment generator in test
1fb09ab
fix folder generator entities--amend
bb592cf
fix folder generator entities--amend
1fad0d4
modified entities react e2e
acb71f6
wait angular admin account client e2e
82fa3f9
try fix e2e
0d30cc9
modified seed db
319a64d
delete unused client template
bcf4697
add more test integration
2ccf0db
modify model
515387e
remove entity client
245d6c3
Update generators/server/templates/server/src/service/auth.service.ts…
d88ecc4
try fix auth react error
754517e
update roadmap
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense? There's no Java in a Node.js-generated project, is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason that I changed it, is that we use the e2e client jhipster tests (I have not overrided the templates of jhipster e2e tests, only for the administration because I have removed the admin java features not supported, such as the logs, metrics), that have assertions for the home title. However, if it is selected the i18n, the home title is replaced with the node hipster customization:
generator-jhipster-nodejs/generators/languages/templates/src/main/webapp/i18n/en/home.json
Line 3 in df15c0e
In the other words, the account test generated is that of jhipster client generator (not overrided from the blueprint): https://github.com/jhipster/generator-jhipster/blob/8f0db2da608b9a76b961c148b4cf6d1ed594c530/generators/client/templates/angular/src/test/javascript/e2e/account/account.spec.ts.ejs#L48