Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User controller error for old express-serve-static-core #120

Closed
Aragonbn90 opened this issue Apr 11, 2020 · 2 comments · Fixed by #122
Closed

User controller error for old express-serve-static-core #120

Aragonbn90 opened this issue Apr 11, 2020 · 2 comments · Fixed by #122
Assignees
Labels
bug Something isn't working

Comments

@Aragonbn90
Copy link
Contributor

Aragonbn90 commented Apr 11, 2020

Describe the bug
User controller got typescript error.

To Reproduce

  1. Use generator-jhipster v 6.8.0, generator-jhipster-nodejs v1.0.1

  2. Create new project:
    mkdir my-app && cd my-app
    jhipster --blueprints nodejs
    ---- Choose Monolithic, JWT, MySQL, React, Default Jhipster theme
    cd server && npm install
    npm start

  3. See error
    Expected behavior
    src/web/rest/user.controller.ts:29:54 - error TS2345: Argument of type 'string | string[] | Query | Query[]' is not assignable to parameter of type 'string | number'.
    const pageRequest: PageRequest = new PageRequest(**req.query.page**, req.query.size, req.query.sort);

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
I've tried on 2 Windows PC and got the same error.
With generator-jhipster-nodejs v1.0.0 I've used before, there's no this kind of error.

@ghost
Copy link

ghost commented Apr 11, 2020

HI @Aragonbn90 , thanks for the feedback!!
Maybe it's a problem of external dependencies, because from v1.0.0 to v1.0.1 it is changed only a thing about the files not published (#118 , your issue). Then, the integration tests for these versions were ok after the release (the integration tests run also the application with a lot of configuration as your) : https://github.com/jhipster/generator-jhipster-nodejs/runs/535960015

ghost pushed a commit that referenced this issue Apr 11, 2020
@ghost ghost assigned Aragonbn90 Apr 11, 2020
@ghost ghost added the bug Something isn't working label Apr 11, 2020
@ghost ghost added this to To do in nodejs blueprint via automation Apr 11, 2020
@ghost ghost linked a pull request Apr 11, 2020 that will close this issue
@ghost ghost changed the title User controller error User controller error for old express-serve-static-core Apr 11, 2020
@ghost
Copy link

ghost commented Apr 11, 2020

Thanks! All perfect! Now you are an official contributor ;) ..https://github.com/jhipster/generator-jhipster-nodejs#contributors-

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant