Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vue issue158 #211

Merged
24 commits merged into from
Mar 31, 2021
Merged

Feature/vue issue158 #211

24 commits merged into from
Mar 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2021

Jhipster 7.0.0 upgrade with vue support:

  • jwt/oauth2 security tested with all client frameworks (angular, react and vue)
  • JDL integration tests (on pipeline) with sql, mongodb, all clients and security
  • Fixed unit test and e2e tests for client and server according jhipster 7.0.0 upgrade (user controller changed on rest api endpoint, that is for admin or public)

This Nhipster blueprint upgrade has required a lot of stuff.

@ghost ghost requested a review from mraible March 26, 2021 14:55
@ghost ghost self-assigned this Mar 26, 2021
@ghost
Copy link
Author

ghost commented Mar 28, 2021

@mraible any feedbacks?

@mraible
Copy link
Contributor

mraible commented Mar 28, 2021

I haven't had a chance to look yet. Maybe tomorrow. In the meantime, maybe other @jhipster/hipsters can help?

This was referenced Mar 29, 2021
@ghost
Copy link
Author

ghost commented Mar 31, 2021

Any news? I have tested locally and with test-integration (github actions) for the required combinations. The e2e tests generated for server and client work fine. So if there aren't feedback, could I consider the feature completed? Thanks

@mraible
Copy link
Contributor

mraible commented Mar 31, 2021

If it works, ship it! 🚢

@ghost ghost merged commit 175bcf2 into main Mar 31, 2021
@ghost ghost deleted the feature/vue-issue158 branch March 31, 2021 17:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue.js support from 7.x jhipster upgrade Unable to create a new entity for jhipster 6.8.0 bug
1 participant