Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci issue 104 #240

Merged
10 commits merged into from
Aug 5, 2021
Merged

Feature/ci issue 104 #240

10 commits merged into from
Aug 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2021

No description provided.

@ghost ghost requested a review from mraible June 11, 2021 14:46
@ghost ghost linked an issue Jun 11, 2021 that may be closed by this pull request
@mraible
Copy link
Contributor

mraible commented Jun 11, 2021

It's probably best to have @mshima or @pascalgrimaud review this one.

@ghost ghost requested review from mshima and pascalgrimaud June 11, 2021 15:25
@ghost
Copy link
Author

ghost commented Jun 29, 2021

Guys, any news?

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could review the generator and GitHub actions.

I can't help with others files.

generators/ci-cd/templates/github-ci.yml.ejs Outdated Show resolved Hide resolved
generators/ci-cd/templates/github-ci.yml.ejs Outdated Show resolved Hide resolved
generators/ci-cd/templates/github-ci.yml.ejs Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.0% 92.0% Coverage
0.0% 0.0% Duplication

@ghost
Copy link
Author

ghost commented Aug 4, 2021

Any news?

@mshima
Copy link
Member

mshima commented Aug 4, 2021

From my side it’s ok, it’s approved.
I just think you should try to add conditions and variables to upstream templates instead of copy the entire template.
Could make maintenance easier.

We probably won’t get a review of the pipelines. It’s too specific.
IMO just go ahead and merge.

@ghost
Copy link
Author

ghost commented Aug 4, 2021

@mshima Thanks for the answer.
I don't know if it is possible to add variables in the templates, because the pipeline for a nodejs app is quite different from the standard jhipster ci-cd.

@ghost ghost merged commit 9ac2fa9 into main Aug 5, 2021
@ghost ghost deleted the feature/ci-issue-104 branch September 4, 2021 11:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci-cd for nodejs application
2 participants