arp 3.1 appears to play too many notes

[dag2099]

Windows 7 64
VCVrack 1.1.4

I've been using Arp 3.1 for a while but I've just noticed that it appears to play an extra note.
Using Merge to put together an 8 part polyphonic signal and then play a melody yields 9 notes instead of 8 when in either "left" or "right" mode. The extra note appears to be have a value of 0.000. Going back over some of my other patches (some of which i've even made videos of) they seem to exhibit the same behavior.
Thx.

[AmalgamatedHarmonics]

HI,

Thanks for feedback. Let me have a look at it and see what's up.

cheers,

john

[jhoar]

I can't reproduce it, with a simple patch (attached) it seems to be ok. Can you give me a patch to test with?

Arp31test.zip

john

[dag2099]

I tried your test patch and it counted 9 numbers one of which was 0.000. for whatever reason it displayed the 0.000 as yellow. Let me just try and redownload your module...
...no it still counts 9 steps rather than 8.

[jhoar]

I am baffled. I'm not sure what else to suggest.

((oops, wrong image))

[AmalgamatedHarmonics]

Sorry, wrong image!

…

On Tue, 10 Sep 2019, 12:50 jhoar, ***@***.***> wrote: I am baffled. I'm not sure what else to suggest. [image: Capture] <https://user-images.githubusercontent.com/13257489/64607707-56d1fb80-d3c9-11e9-8dfa-3ba00414f678.JPG> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#34?email_source=notifications&email_token=AMQQHDAUJWIYM77XJ2P4AV3QI53XZA5CNFSM4IUF2N42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6KVQDY#issuecomment-529881103>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMQQHDBP44MIHKXQ2LVJL3DQI53XZANCNFSM4IUF2N4Q> .

[paulpiko]

This might show the same problem. It plays C4 A4 B4, even though there are only 2 notes, A4 and B4, in the poly cable.

[zyx]

I've been seeing this issue under Linux - Debugging with GDB shows that Arp3.1 is actually calling RightArp::isArpeggioFinished() from ArpeggiatorMkII.cpp. This copy of RightArp::isArpeggioFinished() seems to have an off-by-one bug that causes an extra note to be played.

Removing ArpeggiatorMkII from the plugin fixes the issue, but just renaming Arpeggio and subclasses in ArpeggiatorMkII should also do the trick.

This may also explain VCVRack/library#570

As to the root cause, I'll hazard a guess and say that this may be a linking issue - perhaps there's some link time optimization going on?

[jhoar]

Hi!

Great! Thanks for tracking that down - I was not getting anywhere with that.

john

[zyx]

Hi John, I tried your change but just get a segfault when adding the Arp3.1 module from the browser. Renaming the arpeggiator subclasses (LeftArp -> LeftArp2 etc) in addition to the parent class fixes the issue though.

[AmalgamatedHarmonics]

Great, that's what I have done in fact. Am testing it now with some new stuff. Hope to have it ready next week John

…

On Fri, 29 Nov 2019, 12:40 Luke Andrew, ***@***.***> wrote: Hi John, I tried your change but just get a segfault when adding the Arp3.1 module from the browser. Renaming the arpeggiator subclasses (LeftArp -> LeftArp2 etc) in addition to the parent class fixes the issue though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#34?email_source=notifications&email_token=AMQQHDCG723MWP4TBTEUGEDQWD5TVA5CNFSM4IUF2N42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOU5HA#issuecomment-559763100>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMQQHDFGLLS2I7KTMTPWMMDQWD5TVANCNFSM4IUF2N4Q> .

[jhoar]

Fixed for next release.

[jhoar]

Closed in 1.0.4