Skip to content
This repository has been archived by the owner on Jul 29, 2021. It is now read-only.

feat: add normalization techniques #12

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

EyaRhouma
Copy link

Add 3 new techniques for image normalization:

  • Local contrast normalization module: inspired by computational neuroscience, aims to make the features in feature maps more significant. Paper
  • Local response normalization module: Also inspired by computational neuroscience, aims to reduce the activity of its neighbors and refers to the capacity of a neuron Papers
  • Image smoothing module: helps reduce the noise using OpenCV smoothing techniques (gaussian, averaging, median, bilateral)

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EyaRhouma ,

this looks like a very cool feature.

But I think it may be much better to implement this logic in a different hub executor that can apply torch transformations inspired in https://github.com/jina-ai/jina-hub/tree/master/crafters/image/ImageTorchTransformation

This executor has not been yet ported to 2.0 and our new hub. But maybe we can try to do so

@EyaRhouma EyaRhouma changed the title Feat add normalization techniques 10 feat: add normalization techniques 10 Jul 6, 2021
@EyaRhouma
Copy link
Author

Thank you for your fast response. I completely agree ImageTorchTransformation seems to be a better fit to add the new normalization techniques.
I will move everything there.

@EyaRhouma EyaRhouma changed the title feat: add normalization techniques 10 feat: add normalization techniques Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants