allow jvb and jicofo max_mem env vars to be altered through docker #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
approved these changes
Nov 26, 2023
|
anything preventing this from being merged? |
|
Sorry, I forgot to push the button. |
|
cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #1647, for non containerized setups of jitsi, users can alter the maximum memory limit for java to be set in the respective jvb and jicofo configuration files, but these files are not exposed in
/configfor dockerized installations.while that is the case, the run-scripts for both jvb and jicofo read
JICOFO_MAX_MEMORYandVIDEOBRIDGE_MAX_MEMORYfrom the environment.these patches allow for the same functionality to be restored without the config files needing to be exposed to the main namespace.