Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1655: SENTRY_DSN cannot be defined #1659

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

krombel
Copy link
Contributor

@krombel krombel commented Dec 1, 2023

Fixes #1655

@krombel krombel mentioned this pull request Dec 1, 2023
@DanielMcAssey
Copy link
Contributor

Just FYI, docker-compose defaults to 0 if those env variables arent set, im not sure if .Env.SENTRY_DSN evaluates to true in that regard

@krombel
Copy link
Contributor Author

krombel commented Dec 1, 2023

In that case the library handles that variable as a number. And 0 is handled as false in an if case.

For reference: http://masterminds.github.io/sprig/defaults.html (the underlying library which handles that parsing)

The relevant parts

The definition of “empty” depends on type:

Numeric: 0
[...]

Note that in Go template conditionals, emptiness is calculated for you. Thus, you rarely need if empty .Foo. Instead, just use if .Foo.

@DanielMcAssey
Copy link
Contributor

Perfect! Looks good to me, ill close my PR

@saghul saghul merged commit 71b3892 into jitsi:master Dec 3, 2023
@krombel krombel mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SENTRY_DSN can not be defined
3 participants