Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DESKTOP_SHARING_FRAMERATE_AUTO to allow browser to determine sharing fps automatically #1674

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

cedricroijakkers
Copy link
Contributor

This PR Fixes #1668

The docker containers allow the option to set the screen sharing fps via two environment variables DESKTOP_SHARING_FRAMERATE_MIN and DESKTOP_SHARING_FRAMERATE_MAX. This is fine for people who want to tweak these settings, but on meet.jit.si, these options are left to the defaults. These are that min and max framerate are not configured at all, and that they are therefore left to the browser to determine.

This PR introduces a new environment variable DESKTOP_SHARING_FRAMERATE_AUTO which when set to true, which is the default, does not configure the desktop sharing parameters in the web container at all, i.e. leaving them up to the browser to determine (which is also the behaviour on meet.jit.si). For those who still want to configure their own framerate, they can set DESKTOP_SHARING_FRAMERATE_AUTO to false and configure DESKTOP_SHARING_FRAMERATE_MIN and DESKTOP_SHARING_FRAMERATE_MAX as they wish.

@saghul saghul merged commit 431cdcc into jitsi:master Dec 19, 2023
1 check passed
@saghul
Copy link
Member

saghul commented Dec 19, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen share starts with a low resolution, screens are unreadable for ~30 seconds
2 participants