Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Add env vars for setting 1080p and 4k bitrates. #1729

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

jallamsetty1
Copy link
Member

No description provided.

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of c&p errors

}
}
{{ if .Env.VIDEOQUALITY_BITRATE_AV1_STANDARD }}
config.videoQuality.av1.low = {{ .Env.VIDEOQUALITY_BITRATE_AV1_STANDARD }};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low?

}
}
{{ if .Env.VIDEOQUALITY_BITRATE_AV1_HIGH }}
config.videoQuality.av1.low = {{ .Env.VIDEOQUALITY_BITRATE_AV1_HIGH }};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low?

config.videoQuality.h264 = {};

{{ if .Env.VIDEOQUALITY_BITRATE_H264_LOW }}
config.videoQuality.av1.low = {{ .Env.VIDEOQUALITY_BITRATE_H264_LOW }};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H264

@jallamsetty1
Copy link
Member Author

Lots of c&p errors

Sorry about it! Fixed them.

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jallamsetty1 jallamsetty1 merged commit a1d1f2c into master Jan 31, 2024
1 check passed
@jallamsetty1 jallamsetty1 deleted the add-max-bitrates-4k branch January 31, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants