-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base-java: install nodejs 20 from nodesource #1742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's failed twice on jibri builds, due to something wrong with chromedriver, but it doesn't appear to be related to the changes here.
jibri/Dockerfile
Outdated
@@ -11,7 +11,7 @@ LABEL org.opencontainers.image.documentation="https://jitsi.github.io/handbook/" | |||
ARG USE_CHROMIUM=0 | |||
#ARG CHROME_RELEASE=latest | |||
# https://googlechromelabs.github.io/chrome-for-testing/ | |||
ARG CHROME_RELEASE=121.0.6167.85 | |||
ARG CHROME_RELEASE=121.0.6167.184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try backing out this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this was my attempt to fix the problem. It did not solve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No good I believe this is a separate problem that we need to solve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I built it like that 2 days ago no problem.
I see the problem seems to be the zip file layout, but it would be very odd that they changed the layout for a given version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, the nightly build fails the same way: https://github.com/jitsi/docker-jitsi-meet/actions/runs/7939771467
Please drop that change and I'll look into fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already dropped.
03c4f52
to
6ae8d6e
Compare
No description provided.