jicofo & jvb: Fix OCTO + SCTP behaviour #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Apr 24, 2024
|
@damencho can you PTAL too? |
|
I updated the config template according to @saghul's comment and switched this PR from draft to open. Please let me know if there's anything else that needs to be added. :) |
saghul
reviewed
May 6, 2024
jicofo/rootfs/defaults/jicofo.conf
Outdated
| @@ -4,10 +4,10 @@ | |||
| {{ $AUTH_TYPE := .Env.AUTH_TYPE | default "internal" -}} | |||
| {{ $JICOFO_AUTH_TYPE := .Env.JICOFO_AUTH_TYPE | default $AUTH_TYPE -}} | |||
| {{ $JICOFO_AUTH_LIFETIME := .Env.JICOFO_AUTH_LIFETIME | default "24 hours" -}} | |||
| {{ $ENABLE_SCTP := .Env.ENABLE_SCTP | default "0" | toBool -}} | |||
| {{ $ENABLE_SCTP := .Env.ENABLE_SCTP | default "1" | toBool -}} | |||
There was a problem hiding this comment.
Upon further inspection I think we should keep this defaulting to disabled, for the time being. With the rest of the changes inplace you'll still be able to enable OCTO over SCTP though.
saghul
approved these changes
May 7, 2024
|
Yay! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
As a follow-up to #1787, here's the PR that:
cont-initcheck;I'll leave the PR as a draft for now, until @saghul confirms that all that needed to be done is done. :)