whiteboard.yml: add collaborative whiteboard addon #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Apr 25, 2024
saghul
reviewed
Apr 25, 2024
web/rootfs/defaults/meet.conf
Outdated
| proxy_set_header Connection "upgrade"; | ||
| proxy_set_header Host $http_host; | ||
|
|
||
| proxy_pass http://whiteboard.meet.jitsi/socket.io/?$args; |
There was a problem hiding this comment.
Note to self: In Etherpad we control this with ETHERPAD_URL_BASE, we shuld try to be consistent, but at the same time I'm not sure happy with how the Etherpad settings are done...
Closes: jitsi#1480 Co-authored-by: Tugrul Dogan <[email protected]> Co-authored-by: Saúl Ibarra Corretgé <[email protected]>
saghul
approved these changes
Jul 2, 2024
|
@loli10K I pushed this over the finish line. I'll land it once the CI turns 💚 Sorry for the delay. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an updated version of #1480 since the original author doesn't seem to be active anymore on GitHub.
There are still some things to be done:
jitsi/excalidraw-backenddocker image