Add new environment variables for jigasi configuration #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
reviewed
Jul 1, 2024
| net.java.sip.communicator.impl.neomedia.audioSystem.audiosilence.captureDevice_list=["AudioSilenceCaptureDevice:noTransferData"] | ||
| {{ end }} | ||
|
|
||
| {{ if .Env.JIGASI_CONFIGURATION -}} |
There was a problem hiding this comment.
Same thing as https://github.com/jitsi/docker-jitsi-meet/blob/master/prosody/rootfs/defaults/conf.d/jitsi-meet.cfg.lua#L267 - we are setting some more custom options to finetune Jigasi in our setup, like SIP_PREFERRED_CLEAR_PORT but i thought it wouldnt make sense to expose every possible config option seperated, so JIGASI_CONFIGURATION can be used to render custom snippets inside the config in addition to the predefined options..
aaronkvanmeerten
approved these changes
Jul 1, 2024
damencho
approved these changes
Jul 1, 2024
saghul
added a commit
that referenced
this pull request
Jul 2, 2024
* b4604f3 feat(whiteboard) add builtin whiteboard integration * 49bd165 feat(jibri) update Chrome to 126 * 980703b fix(jibri): display modes in xorg config * c65d2bd feat(jigasi,jicofo,jvb,jibri,prosody): add healthcheck.sh scripts and prosody http_health mod * d2ac43d feat(jigasi): Add new environment variables for jigasi configuration (#1841) * fbc250e feat(prosody): openmetrics module support (#1832) * 2adac72 feat(prosody): Drop non existing config. * e22b4f3 feat(jibri): Adds more fonts. * 982e577 feat(jicofo,jvb,web) default to using SCTP based datachannels * 55c975f fix(jicofo): use integer for port value to fix addition (#1826) * 7c8763f base: update tpl to version 1.3.0 * 1d3c0f1 jibri: fail to start if the SYS_ADMIN cap is missing (#1816) * cacee4e jvb: adds autoscaler sidecar hook to signal final shutdown (#1809) * 726b0f0 jibri: adds autoscaler sidecar hook to signal final shutdown (#1810) * f2b2cc4 etherpad: update image version and settings * 731d6d1 base: update tpl to make toBool more resilient * 59c4eb2 jvb: add fallback WS server ID * 9a54843 jvb: add ability to configure the TLS option for colibri WS * 79a4635 jvb: add ability to disable XMPP * 77ce86a jvb: add ability to enable SCTP datachannels * 76ffaa7 jicofo, jvb: fix OCTO + SCTP behaviour * 0298a30 misc: working on unstable
|
The added environmnt variables don't exist in https://github.com/jitsi/docker-jitsi-meet/blob/master/jigasi.yml |
|
True that @denzs . Can you please add them? |
|
Thanks for pointing that out! see #1856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in https://community.jitsi.org/t/jigasi-sip-dialin-enable-sound-notification/132331/2
We are using
I am open for discussions - of course everythin could be handled with .Env.JIGASI_CONFIGURATION but i think exposing some useful switches makes sense anyhow.. But let me know what you are thinking :)