Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jigasi,transcriber): transcriber component and jigasi configuration updates #1881

Merged
merged 18 commits into from
Sep 3, 2024
Merged

feat(jigasi,transcriber): transcriber component and jigasi configuration updates #1881

merged 18 commits into from
Sep 3, 2024

Conversation

aaronkvanmeerten
Copy link
Member

No description provided.

@aaronkvanmeerten aaronkvanmeerten changed the title Transcriber-xmpp-account feat(prosody): transcriber xmpp account support Aug 20, 2024
saghul
saghul reviewed Aug 21, 2024
View reviewed changes
jigasi/rootfs/etc/cont-init.d/10-config Outdated Show resolved Hide resolved
jigasi/rootfs/etc/cont-init.d/10-config Outdated Show resolved Hide resolved
prosody/rootfs/etc/cont-init.d/10-config Outdated Show resolved Hide resolved
jigasi/rootfs/defaults/sip-communicator.properties Outdated Show resolved Hide resolved
jigasi/rootfs/defaults/sip-communicator.properties Outdated Show resolved Hide resolved
transcriber.yml Outdated Show resolved Hide resolved
transcriber.yml Outdated Show resolved Hide resolved
transcriber.yml Outdated Show resolved Hide resolved
aaronkvanmeerten
aaronkvanmeerten commented Aug 28, 2024
View reviewed changes
Copy link
Member Author

@aaronkvanmeerten aaronkvanmeerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I've made the requested changes and hope to have another review

@aaronkvanmeerten aaronkvanmeerten mentioned this pull request Aug 28, 2024
Open
damencho
damencho requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a docker guru, but spotted a few jigasi-related config problems.

jigasi/rootfs/defaults/transcriber-sip-communicator.properties Outdated Show resolved Hide resolved
jigasi.yml Show resolved Hide resolved
@aaronkvanmeerten aaronkvanmeerten changed the title feat(prosody): transcriber xmpp account support feat(prosody,jigasi,web,jicofo): transcriber workflow and configuration updates Aug 30, 2024
@aaronkvanmeerten aaronkvanmeerten changed the title feat(prosody,jigasi,web,jicofo): transcriber workflow and configuration updates feat(jigasi,transcriber): transcriber component and jigasi configuration updates Aug 30, 2024
@aaronkvanmeerten
Copy link
Member Author

ok I believe I have trimmed down all the extraneous changes here, and would love a review from @saghul once he's returned and has a brain for such. I have tested the transcriber part in compose and in nomad and both eventually worked. I have not tested the sip part since the changes.

saghul
saghul approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 👏

@aaronkvanmeerten aaronkvanmeerten merged commit 3f67408 into master Sep 3, 2024
1 check passed
@aaronkvanmeerten aaronkvanmeerten deleted the transcriber-xmpp-account branch September 3, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

@sawall sawall sawall approved these changes

@damencho damencho damencho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronkvanmeerten @saghul @sawall @damencho