Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename placement methods to fix objc issues #112

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Jan 11, 2018

fixes #111

@jjochen jjochen added this to the 0.7.2 milestone Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         792    792           
  Branches       25     25           
=====================================
  Hits          792    792
Impacted Files Coverage Δ
Sources/JJFloatingActionButton.swift 100% <100%> (ø) ⬆️
Sources/JJFloatingActionButton+Placement.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc2334...16e24ab. Read the comment docs.

@jjochen jjochen merged commit 57448d4 into master Jan 11, 2018
@jjochen jjochen deleted the feature/objc-placement branch January 11, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placement methods not accessible from objective-c
1 participant