Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item layout in circular pop up style #171

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Nov 28, 2018

No description provided.

@jjochen jjochen added the fixed label Nov 28, 2018
@jjochen jjochen added this to the 1.0.0 milestone Nov 28, 2018
@jjochen
Copy link
Owner Author

jjochen commented Nov 28, 2018

fixes #170

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #171   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         453    456    +3     
=====================================
+ Hits          453    456    +3
Impacted Files Coverage Δ
Sources/JJActionItem.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0dca7...41325a9. Read the comment docs.

@jjochen jjochen changed the title item tap area is overlapping with circular pop up style Item tap area is overlapping with circular pop up style Nov 29, 2018
@jjochen jjochen changed the title Item tap area is overlapping with circular pop up style Fix item layout in circular pop up style Nov 29, 2018
@jjochen jjochen merged commit ecec082 into master Nov 29, 2018
@jjochen jjochen deleted the fix/overlapping_tap_area branch November 29, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant