Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default button size configurable #188

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Feb 1, 2019

No description provided.

@jjochen jjochen added the added label Feb 1, 2019
@jjochen jjochen added this to the 1.2.0 milestone Feb 1, 2019
@jjochen jjochen changed the title Make the default button size configurable Make default button size configurable Feb 1, 2019
@jjochen jjochen merged commit ff110f7 into master Feb 1, 2019
@jjochen jjochen deleted the feature/default-button-size branch February 1, 2019 09:45
@wdcurry
Copy link

wdcurry commented Feb 3, 2019

I updated my repo and used buttonDiameter = 33 (for example), fires up great, but tapping the button leads to a larger (likely 56) sized button that is (of course) offset a bit from the smaller one. I can live with this as-is but if feels off. Perhaps my bits are messed up?

@wdcurry
Copy link

wdcurry commented Feb 3, 2019

I temporarily solved this with:
actionButton.widthAnchor.constraint(equalToConstant: actionButton.buttonDiameter ).isActive = true
actionButton.heightAnchor.constraint(equalToConstant: actionButton.buttonDiameter ).isActive = true

@jjochen
Copy link
Owner Author

jjochen commented Feb 4, 2019

I opened an issue: #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants