Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift Package Manager #228

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Support for Swift Package Manager #228

merged 4 commits into from
Feb 28, 2020

Conversation

jaimefere
Copy link
Contributor

To import library with SPM in Xcode 11.3.1 (Swift 5.1).

Specify platforms in Package.swift
Change from swift 4.2 version to 5.1
To solve "Use of undeclared type 'CGFloat'; did you mean to use 'CGFloat'?" error
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #228   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         978    978           
=====================================
  Hits          978    978
Impacted Files Coverage Δ
Sources/AnimationConfiguration.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a84c5...d40671a. Read the comment docs.

@jjochen jjochen changed the title Swift Package Manager Support for Swift Package Manager Feb 27, 2020
Sources/AnimationConfiguration.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
@jjochen
Copy link
Owner

jjochen commented Feb 27, 2020

Thank You @jaimefere!

@jjochen jjochen added this to the 2.2.0 milestone Feb 28, 2020
@jjochen jjochen merged commit e1cba26 into jjochen:master Feb 28, 2020
@jaimefere
Copy link
Contributor Author

Thank You @jaimefere!

Thank you for a great job! 👏🏽👏🏽

zalexej pushed a commit to zalexej/JJFloatingActionButton that referenced this pull request Mar 6, 2020
* Update Package.swift

Specify platforms in Package.swift

* Update Package.swift

Change from swift 4.2 version to 5.1

* Update AnimationConfiguration.swift

To solve "Use of undeclared type 'CGFloat'; did you mean to use 'CGFloat'?" error

* Apply suggestions from code review

Co-authored-by: Jochen Pfeiffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants