Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic closing of action button configurable #231

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Feb 28, 2020

No description provided.

@jjochen jjochen linked an issue Feb 28, 2020 that may be closed by this pull request
@jjochen jjochen added the added label Feb 28, 2020
@jjochen jjochen added this to the 2.2.0 milestone Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #231   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         978    979    +1     
=====================================
+ Hits          978    979    +1
Impacted Files Coverage Δ
Sources/JJFloatingActionButton.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4030528...a81be7e. Read the comment docs.

@jjochen jjochen merged commit 19d8214 into master Feb 28, 2020
@jjochen jjochen deleted the feature/auto_close branch February 28, 2020 15:25
zalexej pushed a commit to zalexej/JJFloatingActionButton that referenced this pull request Mar 6, 2020
* Make automatic closing of action button configurable

* improve related tests in JJFloatingActionButtonSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave action items visible
1 participant