Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent item selection during closing animation #234

Merged

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Mar 1, 2020

No description provided.

@jjochen jjochen added the changed label Mar 1, 2020
@jjochen jjochen added this to the 2.2.0 milestone Mar 1, 2020
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #234   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         981    984    +3     
=====================================
+ Hits          981    984    +3
Impacted Files Coverage Δ
Sources/JJFloatingActionButton.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283032e...d25864c. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #234 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          981       984    +3     
=========================================
+ Hits           981       984    +3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283032e...d25864c. Read the comment docs.

@jjochen jjochen merged commit 68b3464 into master Mar 1, 2020
@jjochen jjochen deleted the feature/prevent-item-selection-during-closing-animation branch March 1, 2020 14:12
zalexej pushed a commit to zalexej/JJFloatingActionButton that referenced this pull request Mar 6, 2020
* add test for double tap on action item

* prevent items to be tapped during closing animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant