Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience methods to remove action items from the button #240

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Mar 4, 2020

resolves #239

Adds two methods:

func removeItem(_ item: JJActionItem) -> JJActionItem?
func removeItem(at index: Int) -> JJActionItem

@jjochen jjochen added the added label Mar 4, 2020
@jjochen jjochen added this to the 2.2.1 milestone Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #240 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #240   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         995   1000    +5     
=====================================
+ Hits          995   1000    +5
Impacted Files Coverage Δ
Sources/JJFloatingActionButton.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a126a...ad3e862. Read the comment docs.

@jjochen jjochen merged commit d8d7aae into master Mar 4, 2020
@jjochen jjochen deleted the feature/add_method_to_remove_item branch March 4, 2020 16:01
zalexej pushed a commit to zalexej/JJFloatingActionButton that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to remove action item
1 participant