Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image transition when button opens/closes #46

Merged
merged 5 commits into from
Dec 13, 2017

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Dec 13, 2017

resolves #45

@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #46   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         596    655   +59     
  Branches       20     23    +3     
=====================================
+ Hits          596    655   +59
Impacted Files Coverage Δ
...nButton/Classes/Extensions/UIView+Extensions.swift 100% <100%> (ø) ⬆️
...gActionButton/Classes/JJFloatingActionButton.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b448edb...03dc545. Read the comment docs.

@jjochen jjochen merged commit 432f842 into master Dec 13, 2017
@jjochen jjochen deleted the feature/image_transition branch December 13, 2017 13:02
@jjochen jjochen added this to the 0.5.0 milestone Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if imageView and openImageView can be merged into one
1 participant