Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snapmaker Luban support #123

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Conversation

Golumpa
Copy link
Contributor

@Golumpa Golumpa commented Feb 8, 2024

In the latest version of Luban, the formatting has changed slightly. (I am not sure when it was changed, I only just started using Luban)

Was
;thumbnail: data:image/png;base64,

Now
;Thumbnail:data:image/png;base64,

This adds Luban support back. This will only work with newly sliced gcodes.

Had to rename to txt due to github restrictions but here is a newly sliced benchy.
3DBenchy_1706529863352.gcode.txt

Golumpa and others added 2 commits February 8, 2024 18:07
In the latest version of Luban the formatting has changed slightly. This adds Luban support back. This will only work with newly sliced gcodes.
@jneilliii
Copy link
Owner

jneilliii commented Feb 8, 2024

Could you do me a favor and validate the change I just committed to your PR, which should allow for both use cases?

;[Tt]humbnail: ?data:image/png;base64,(.*)[\r\n]

Copy link
Contributor Author

@Golumpa Golumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not good with regex but this would be a much preferable way of doing it.

@Golumpa
Copy link
Contributor Author

Golumpa commented Feb 9, 2024

Now that I have finished my 20 hour print, I can confirm it is working as intended.

I downloaded the GCode from the original implementation #91 and both the new and old GCode displays an image now

Screenshot 2024-02-09 134641

@jneilliii
Copy link
Owner

Thanks for confirming.

@jneilliii jneilliii merged commit 398a7a1 into jneilliii:master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants